Supplement callback type and reverted helper change

mitchheddles · mitchheddles · commit d3b78e3e07d1 · 2018-05-23T14:46:47.000+10:00
diff --git a/generate/input/libgit2-supplement.json b/generate/input/libgit2-supplement.json
@@ -699,7 +699,7 @@
               "name": "transfer_progress"
             },
             {
-              "type": "git_push_transfer_progress",
+              "type": "git_push_transfer_progress_cb",
               "name": "push_transfer_progress"
             },
             {
diff --git a/generate/scripts/helpers.js b/generate/scripts/helpers.js
@@ -85,12 +85,6 @@ var Helpers = {
   },
 
   isCallbackFunction: function(cType) {
-    // NOTE: Added this just to get it working, I'm not sure how else to get
-    // around this, as the fieldOverrides are applied after this.
-    if (cType === 'git_push_transfer_progress') {
-      return true;
-    }
-
     return callbackTypePattern.test(cType);
   },
 

Original file line number	Diff line number	Diff line change
`@@ -699,7 +699,7 @@`
`699`	`699`	`"name": "transfer_progress"`
`700`	`700`	`},`
`701`	`701`	`{`
`702`		`- "type": "git_push_transfer_progress",`
	`702`	`+ "type": "git_push_transfer_progress_cb",`
`703`	`703`	`"name": "push_transfer_progress"`
`704`	`704`	`},`
`705`	`705`	`{`