Make the message argument of Stash.save optional

rcjsuen · rcjsuen · commit a5fa89c7625c · 2017-02-06T19:49:43.000+09:00
libgit2's git_stash_save function does not actually require the
message to be set. One will be generated if a message is not given so
the parameter should be flagged as being optional in NodeGit as well.
diff --git a/generate/input/descriptor.json b/generate/input/descriptor.json
@@ -2175,6 +2175,11 @@
           }
         },
         "git_stash_save": {
+          "args": {
+            "message": {
+              "isOptional": true
+            }
+          },
           "isAsync": true,
           "return": {
             "isErrorCode": true
diff --git a/test/tests/stash.js b/test/tests/stash.js
@@ -31,15 +31,13 @@ describe("Stash", function() {
       });
   });
 
-  it("can save and drop a stash", function() {
+  function saveDropStash(repo, stashMessage) {
     var fileName = "README.md";
     var fileContent = "Cha-cha-cha-chaaaaaangessssss";
-    var repo = this.repository;
     var filePath = path.join(repo.workdir(), fileName);
     var oldContent;
     var stashes = [];
     var stashOid;
-    var stashMessage = "stash test";
 
     return fse.readFile(filePath)
       .then(function(content) {
@@ -82,6 +80,14 @@ describe("Stash", function() {
             return Promise.reject(e);
           });
       });
+  }
+
+  it("can save and drop a stash", function() {
+    saveDropStash(this.repository, "stash test");
+  });
+
+  it("can save a stash with no message and drop it", function() {
+    saveDropStash(this.repository, null);
   });
 
   it("can save and pop a stash", function() {
