Convert Buf.prototype.set and Buf.prototype.grow to sync methods

implausible · implausible · commit a373d92cc057 · 2019-01-28T13:31:51.000-07:00
diff --git a/generate/input/descriptor.json b/generate/input/descriptor.json
@@ -401,7 +401,7 @@
             "jsClassName": "Number",
             "isErrorCode": true
           },
-          "isAsync": true
+          "isAsync": false
         },
         "git_buf_set": {
           "cppFunctionName": "Set",
@@ -422,7 +422,7 @@
             "jsClassName": "Number",
             "isErrorCode": true
           },
-          "isAsync": true
+          "isAsync": false
         }
       },
       "dependencies": [
diff --git a/test/tests/filter.js b/test/tests/filter.js
@@ -476,10 +476,8 @@ describe("Filter", function() {
 
       return Registry.register(filterName, {
         apply: function(to, from, source) {
-          return to.set(tempBuffer, length)
-            .then(function() {
-              return NodeGit.Error.CODE.PASSTHROUGH;
-            });
+          to.set(tempBuffer, length);
+          return NodeGit.Error.CODE.PASSTHROUGH;
         },
         check: function() {
           return NodeGit.Error.CODE.OK;
@@ -522,10 +520,8 @@ describe("Filter", function() {
 
       return Registry.register(filterName, {
         apply: function(to, from, source) {
-          return to.set(tempBuffer, length)
-            .then(function() {
-              return NodeGit.Error.CODE.OK;
-            });
+          to.set(tempBuffer, length);
+          return NodeGit.Error.CODE.OK;
         },
         check: function(src, attr) {
           return NodeGit.Error.CODE.OK;
@@ -568,10 +564,8 @@ describe("Filter", function() {
 
         return Registry.register(filterName, {
           apply: function(to, from, source) {
-            return to.set(largeBuffer, largeBufferSize)
-            .then(function() {
-              return NodeGit.Error.CODE.OK;
-            });
+            to.set(largeBuffer, largeBufferSize);
+            return NodeGit.Error.CODE.OK;
           },
           check: function(src, attr) {
             return NodeGit.Error.CODE.OK;
@@ -626,10 +620,8 @@ describe("Filter", function() {
 
       return Registry.register(filterName, {
         apply: function(to, from, source) {
-          return to.set(tempBuffer, length)
-            .then(function() {
-              return NodeGit.Error.CODE.OK;
-            });
+          to.set(tempBuffer, length);
+          return NodeGit.Error.CODE.OK;
         },
         check: function(src, attr) {
           return NodeGit.Error.CODE.OK;
@@ -668,10 +660,8 @@ describe("Filter", function() {
 
       return Registry.register(filterName, {
         apply: function(to, from, source) {
-          return to.set(tempBuffer, length)
-            .then(function() {
-              return NodeGit.Error.CODE.OK;
-            });
+          to.set(tempBuffer, length);
+          return NodeGit.Error.CODE.OK;
         },
         check: function(src, attr) {
           return src.path() === "README.md" ?
@@ -725,10 +715,8 @@ describe("Filter", function() {
 
       return Registry.register(filterName, {
         apply: function(to, from, source) {
-          return to.set(tempBuffer, length)
-            .then(function() {
-              return NodeGit.Error.CODE.OK;
-            });
+          to.set(tempBuffer, length);
+          return NodeGit.Error.CODE.OK;
         },
         check: function(src, attr) {
           return src.path() === "README.md" ?
@@ -956,10 +944,8 @@ describe("Filter", function() {
 
       return Registry.register(filterName, {
         apply: function(to, from, source) {
-          return to.set(tempBuffer, length)
-            .then(function() {
-              return NodeGit.Error.CODE.OK;
-            });
+          to.set(tempBuffer, length);
+          return NodeGit.Error.CODE.OK;
         },
         check: function(src, attr) {
           return NodeGit.Error.CODE.OK;
@@ -999,10 +985,8 @@ describe("Filter", function() {
 
       return Registry.register(filterName, {
         apply: function(to, from, source) {
-          return to.set(tempBuffer, length)
-            .then(function() {
-              return NodeGit.Error.CODE.OK;
-            });
+          to.set(tempBuffer, length);
+          return NodeGit.Error.CODE.OK;
         },
         check: function(src, attr) {
           return NodeGit.Error.CODE.OK;
@@ -1044,10 +1028,8 @@ describe("Filter", function() {
 
       return Registry.register(filterName, {
         apply: function(to, from, source) {
-          return to.set(tempBuffer, length)
-            .then(function() {
-              return NodeGit.Error.CODE.OK;
-            });
+          to.set(tempBuffer, length);
+          return NodeGit.Error.CODE.OK;
         },
         check: function(src, attr) {
           return NodeGit.Error.CODE.OK;
