Mark tree entry as selfFreeing

srajko · srajko · commit 80937a353b7c · 2016-10-07T09:21:47.000-07:00
diff --git a/generate/input/descriptor.json b/generate/input/descriptor.json
@@ -2499,10 +2499,16 @@
           }
         },
         "git_tree_entry_byindex": {
-          "jsFunctionName": "_entryByIndex"
+          "jsFunctionName": "_entryByIndex",
+          "return": {
+            "ownedByThis": true
+          }
         },
         "git_tree_entry_byname": {
-          "jsFunctionName": "_entryByName"
+          "jsFunctionName": "_entryByName",
+          "return": {
+            "ownedByThis": true
+          }
         },
         "git_tree_entrycount": {
           "jsFunctionName": "entryCount"
@@ -2539,6 +2545,7 @@
       }
     },
     "tree_entry": {
+      "selfFreeing": true,
       "dupFunction": "git_tree_entry_dup",
       "freeFunctionName": "git_tree_entry_free",
       "functions": {
diff --git a/generate/scripts/helpers.js b/generate/scripts/helpers.js
@@ -251,7 +251,7 @@ var Helpers = {
     arg.cppClassName = Helpers.cTypeToCppName(arg.cType);
     arg.jsClassName = utils.titleCase(Helpers.cTypeToJsName(arg.cType));
 
-    var libgitType = Helpers.decorateLibgitType(arg, libgit2.types, enums);
+    Helpers.decorateLibgitType(arg, libgit2.types, enums);
 
     // Some arguments can be callbacks
     if (Helpers.isCallbackFunction(type)) {
@@ -280,11 +280,6 @@ var Helpers = {
           argOverrides.cppClassName !== "Array" &&
           _.every(allArgs, function(_arg) { return !_arg.isSelf; });
       }
-
-      if (arg.isReturn && libgitType)  {
-        arg.selfFreeing = libgitType.selfFreeing;
-      }
-
       if (arg.isReturn && fnDef.return && fnDef.return.type === "int") {
         fnDef.return.isErrorCode = true;
         fnDef.isAsync = true;
