Add descriptor support for selfFreeing

srajko · srajko · commit 1abdd394fcf2 · 2016-03-23T16:20:45.000-07:00
diff --git a/generate/scripts/helpers.js b/generate/scripts/helpers.js
@@ -143,6 +143,7 @@ var Helpers = {
     }
   },
 
+  // returns the libgittype found in types
   decorateLibgitType: function(type, types, enums) {
     var normalizedType = Helpers.normalizeCtype(type.cType);
     var libgitType = Helpers.getLibgitType(normalizedType, types);
@@ -164,6 +165,8 @@ var Helpers = {
       // we don't want to overwrite the c type of the passed in type
       _.merge(type, descriptor.types[normalizedType.replace("git_", "")] || {}, { cType: type.cType });
     }
+
+    return libgitType;
   },
 
   decoratePrimaryType: function(typeDef, enums) {
@@ -176,6 +179,7 @@ var Helpers = {
     typeDef.filename = typeDef.typeName;
     typeDef.isLibgitType = true;
     typeDef.dependencies = [];
+    typeDef.selfFreeing = Boolean(typeDefOverrides.selfFreeing);
 
     typeDef.fields = typeDef.fields || [];
     typeDef.fields.forEach(function (field, index, allFields) {
@@ -241,7 +245,7 @@ var Helpers = {
     arg.cppClassName = Helpers.cTypeToCppName(arg.cType);
     arg.jsClassName = utils.titleCase(Helpers.cTypeToJsName(arg.cType));
 
-    Helpers.decorateLibgitType(arg, libgit2.types, enums);
+    var libgitType = Helpers.decorateLibgitType(arg, libgit2.types, enums);
 
     // Some arguments can be callbacks
     if (Helpers.isCallbackFunction(type)) {
@@ -271,6 +275,10 @@ var Helpers = {
           _.every(allArgs, function(_arg) { return !_arg.isSelf; });
       }
 
+      if (arg.isReturn && libgitType)  {
+        arg.selfFreeing = libgitType.selfFreeing;
+      }
+
       if (arg.isReturn && fnDef.return && fnDef.return.type === "int") {
         fnDef.return.isErrorCode = true;
         fnDef.isAsync = true;
