#4038 Use adder only for the matching collection property - #4116
Open
tanvir-ux wants to merge 1 commit into
Open
#4038 Use adder only for the matching collection property#4116tanvir-ux wants to merge 1 commit into
tanvir-ux wants to merge 1 commit into
Conversation
A single type-compatible adder was applied to every collection of that element type. Match adder names to the property (singular first, then exact) so other lists keep their own setters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4038.
With
CollectionMappingStrategy.ADDER_PREFERRED, a single adder such as Lombok@Singular("addItem")was reused for every collection of the same element type (moreItemsended up callingaddItem).getAdderForTypenow requires the adder name to match the property (singular form first, then the exact name). An unmatched adder is not used, so the property keeps its setter.Processor tests:
Issue4038Test,AdderTest.