#3948 Generic types of declared type must match exactly#4059
Merged
Conversation
Declared generics must match exactly (e.g. `Comparable<Number>` cannot match `Comparable<Long>)`. Recursive resolution of mismatched generics can cause infinite loops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3948 and #3945.
The main issue was that MapStruct tries to match declared generic types even when they are not compatible. This results in an infinite loop when the type has a self-reference.
I used a modified version of the code provided in #3948 as a test case. I also manually tested the scenario using the repository linked in #3945 with local fixes applied.