upgrade integration tests to junit5#4023
Merged
filiphr merged 1 commit intoMar 27, 2026
Merged
Conversation
Member
|
Thanks @hduelme. Mostly it looks OK. I'm curious, why couldn't we upgrade to JUnit 6 everywhere? What isn't working if we do that? |
Contributor
Author
|
@filiphr I attempted to upgrade to JUnit 6, but encountered a compatibility issue. |
Member
|
Gotcha, thanks @hduelme. I guess we are soon going to need to bump to Java 17 as baseline. But let's do that after MapStruct 1.7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compile tests were still using
JUnit4. This PR fully migrates the integration tests toJUnit5.To achieve this:
Arquillianto version1.7.2.Final(newer versions currently cause issues with@WithCdi)JUnit6by overriding theorg.junit.jupiter.versionproperty. (springframeworkversion 7 requiresJUnit6)JUnit5conventions and code style across the test suite