Enforce spaces inside parentheses for control flow statements via checkstyle#4016
Merged
filiphr merged 2 commits intomapstruct:mainfrom Mar 27, 2026
Merged
Conversation
Contributor
|
In #3994, Claude Code found a missing check for the import order. Maybe we could add this. After merging, the new rules should also be applied to mapstruct-idea to prevent unexpected errors in future PRs. |
Member
Author
|
Good point. That PR was a trigger for me to do this with Claude Code. I'll look into the import order as well |
filiphr
force-pushed
the
checkstyle-parenpad-control-flow
branch
2 times, most recently
from
57bbb86 to
f6d7d34
Compare
filiphr
force-pushed
the
checkstyle-parenpad-control-flow
branch
from
f6d7d34 to
3073dbb
Compare
Add CustomImportOrder module to checkstyle configuration enforcing: 1. java/javax imports (STANDARD_JAVA_PACKAGE) 2. Third-party imports (THIRD_PARTY_PACKAGE) 3. org.hibernate imports (SPECIAL_IMPORTS) 4. Static imports (STATIC) With alphabetical sorting within groups and blank line separators between groups, matching the existing IntelliJ formatter configuration.
filiphr
force-pushed
the
checkstyle-parenpad-control-flow
branch
from
3073dbb to
16a28e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.