Skip to content

improve performance of Type.describe() by removing regex matching #3991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hduelme wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

improve performance of Type.describe() by removing regex matching #3991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion processor/src/main/java/org/mapstruct/ap/internal/model/common/Type.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1331,7 +1331,7 @@ public String describe() {
}
else {
// name allows for inner classes
String name = getFullyQualifiedName().replaceFirst( "^" + getPackageName() + ".", "" );
String name = getNameKeepingInnerClasses();
List<Type> typeParams = getTypeParameters();
if ( typeParams.isEmpty() ) {
return name;
Expand All @@ -1343,6 +1343,15 @@ public String describe() {
}
}

private String getNameKeepingInnerClasses() {
String packageNamePrefix = getPackageName() + ".";
String fullyQualifiedName = getFullyQualifiedName();
if (fullyQualifiedName.startsWith( packageNamePrefix ) ) {
return fullyQualifiedName.substring( packageNamePrefix.length() );
}
return fullyQualifiedName;
}

/**
*
* @return an identification that can be used as part in a forged method name.
Expand Down