Skip to content

#3886: Records do not have property write accessors (apart from the record components) #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filiphr merged 1 commit into from
Jun 14, 2025
Merged

#3886: Records do not have property write accessors (apart from the record components) #3888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions processor/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<testRelease>${minimum.java.version}</testRelease>
<annotationProcessorPaths>
<path>
<groupId>org.mapstruct.tools.gem</groupId>
Expand Down
4 changes: 4 additions & 0 deletions processor/src/main/java/org/mapstruct/ap/internal/model/common/Type.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,6 +796,10 @@ public Map<String, PresenceCheckAccessor> getPropertyPresenceCheckers() {
* @return an unmodifiable map of all write accessors indexed by property name
*/
public Map<String, Accessor> getPropertyWriteAccessors( CollectionMappingStrategyGem cmStrategy ) {
if ( isRecord() ) {
// Records do not have setters, so we return an empty map
return Collections.emptyMap();
}
// collect all candidate target accessors
List<Accessor> candidates = new ArrayList<>( getSetters() );
candidates.addAll( getAlternativeTargetAccessors() );
Expand Down
31 changes: 31 additions & 0 deletions processor/src/test/java/org/mapstruct/ap/test/bugs/_3886/jdk21/Issue3886Mapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/*
* Copyright MapStruct Authors.
*
* Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
*/
package org.mapstruct.ap.test.bugs._3886.jdk21;

import java.time.LocalDate;

import org.mapstruct.Mapper;
import org.mapstruct.ReportingPolicy;

/**
* @author Filip Hrisafov
*/
@Mapper(unmappedTargetPolicy = ReportingPolicy.ERROR)
public interface Issue3886Mapper {

RangeRecord map(LocalDate validFrom);

record RangeRecord(LocalDate validFrom) {

public RangeRecord restrictTo(RangeRecord other) {
return null;
}

public void setName(String name) {
// This method is here to ensure that MapStruct won't treat it as a setter
}
}
}
25 changes: 25 additions & 0 deletions processor/src/test/java/org/mapstruct/ap/test/bugs/_3886/jdk21/Issue3886Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/*
* Copyright MapStruct Authors.
*
* Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
*/
package org.mapstruct.ap.test.bugs._3886.jdk21;

import org.mapstruct.ap.testutil.IssueKey;
import org.mapstruct.ap.testutil.ProcessorTest;
import org.mapstruct.ap.testutil.WithClasses;
import org.mapstruct.ap.testutil.runner.Compiler;

/**
* @author Filip Hrisafov
*/
@WithClasses(Issue3886Mapper.class)
@IssueKey("3886")
class Issue3886Test {

// The current version of the Eclipse compiler we use does not support records
@ProcessorTest(Compiler.JDK)
void shouldCompile() {

}
}