refactor & fix: Merge ExecutableElementAccessor into ElementAccessor and add generic support uniformly#3872
Merged
filiphr merged 2 commits intomapstruct:mainfrom May 31, 2025
Merged
Conversation
…and add generic support uniformly Signed-off-by: TangYang <tangyang9464@163.com>
filiphr
approved these changes
May 31, 2025
Member
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
Thanks @tangyang9464. I did a small polish and will merge it once the build passes
tangyang9464
commented
Jun 5, 2025
|
|
||
| public class Issue3807Test { | ||
| @WithClasses(Issue3807Mapper.class) | ||
| @IssueKey("3087") |
Contributor
Author
There was a problem hiding this comment.
I just suddenly found that the issueskey was written wrongly as 3087
Member
There was a problem hiding this comment.
Sorry that's my mistake @tangyang9464. I was adding the IssueKey in my polishing and I made a typo. I've fixed this in f4d1818
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #3807
Made some refactoring to Accessor:
ExecutableElementAccessorandParameterElementAccessorintoElementAccessor（DeletedExecutableElementAccessor、ParameterElementAccessor）RecordElementAccessor(it is not used anywhere and the related functions are replaced byReadAccessor)accessedTypefield toElementAccessorto handle generics