#3821 feat: add support for custom exception in subclass mapping#3853
Merged
filiphr merged 3 commits intomapstruct:mainfrom May 17, 2025
Merged
#3821 feat: add support for custom exception in subclass mapping#3853filiphr merged 3 commits intomapstruct:mainfrom
filiphr merged 3 commits intomapstruct:mainfrom
Conversation
…ping Signed-off-by: TangYang <tangyang9464@163.com>
tangyang9464
force-pushed
the
feature/issues#3821
branch
from
0bf813e to
a64e8a4
Compare
filiphr
reviewed
May 13, 2025
Member
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
This looks as expected @tangyang9464, I've left one comment and can you please make sure that you remove the whitespace changes from the BeanMappingMethod, you don't need to reformat the entire file, only what you have changed.
processor/src/main/java/org/mapstruct/ap/internal/model/BeanMappingMethod.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
For the first time, I applied the entire file formatting. I found that there were many changes. I gave up and then the CICD failed. So I executed the formatting again. I thought that all the code in the project was in line with the specifications. But it seems that some historical code was not like that. I will manually remove those changes that are not mine. |
Signed-off-by: TangYang <tangyang9464@163.com>
Contributor
Author
|
@filiphr plz review again |
Member
|
Thanks @tangyang9464 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close issue#3821
I implemented subclassExhaustiveException with reference to subclassExhaustiveStrategy, so this custom exception supports configuration on mapper, mapperConfig, and BeanMapping.
plz review @filiphr