#3747 Fix empty if-block when NullValueMappingStrategy is RETURN_DEFAULT and target is immutable#3749
Closed
Hypnagokali wants to merge 1 commit intomapstruct:mainfrom
Closed
#3747 Fix empty if-block when NullValueMappingStrategy is RETURN_DEFAULT and target is immutable#3749Hypnagokali wants to merge 1 commit intomapstruct:mainfrom
Hypnagokali wants to merge 1 commit intomapstruct:mainfrom
Conversation
…TURN_DEFAULT and target is immutable
Member
|
Sorry I missed this @Hypnagokali and I already did #3758, so closing this in favor of that one. I also prefer the solution in my PR as it is slightly simpler then this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3747
Problem:
The BeanMappingMethod template always creates the if-block for the property mappings, even if the target only has constructor mappings.
The unit tests are green but when I run "mvnw install" I get an exception from the maven shade plugin. The exception disappears when I set the version to 3.2.1