#3707 Fix abstract generic builder mappings#3748
Open
Obolrom wants to merge 8 commits intomapstruct:mainfrom
Open
#3707 Fix abstract generic builder mappings#3748Obolrom wants to merge 8 commits intomapstruct:mainfrom
Obolrom wants to merge 8 commits intomapstruct:mainfrom
Conversation
filiphr
requested changes
Oct 20, 2024
Member
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
Thanks for the PR @Obolrom. However, I do not like the solution. The fact that the method returns a generic type var type does not mean that it should be treated as a potential fluent setter.
In this phase we should be able to determine the generic return type to an actual type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug #3707