Skip to content

#3717 Fix ClassCastException when getting thrown types for a record accessor #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filiphr merged 1 commit into from
Sep 16, 2024
Merged

#3717 Fix ClassCastException when getting thrown types for a record accessor #3718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .../test/resources/recordsTest/src/main/java/org/mapstruct/itest/records/nested/Address.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/*
* Copyright MapStruct Authors.
*
* Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
*/
package org.mapstruct.itest.records.nested;

/**
* @author Filip Hrisafov
*/
public record Address(String street, String city) {

}
13 changes: 13 additions & 0 deletions .../resources/recordsTest/src/main/java/org/mapstruct/itest/records/nested/CareProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/*
* Copyright MapStruct Authors.
*
* Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
*/
package org.mapstruct.itest.records.nested;

/**
* @author Filip Hrisafov
*/
public record CareProvider(String externalId, Address address) {

}
13 changes: 13 additions & 0 deletions ...sources/recordsTest/src/main/java/org/mapstruct/itest/records/nested/CareProviderDto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/*
* Copyright MapStruct Authors.
*
* Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
*/
package org.mapstruct.itest.records.nested;

/**
* @author Filip Hrisafov
*/
public record CareProviderDto(String id, String street, String city) {

}
25 changes: 25 additions & 0 deletions ...rces/recordsTest/src/main/java/org/mapstruct/itest/records/nested/CareProviderMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/*
* Copyright MapStruct Authors.
*
* Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
*/
package org.mapstruct.itest.records.nested;

import org.mapstruct.Mapper;
import org.mapstruct.Mapping;
import org.mapstruct.ReportingPolicy;
import org.mapstruct.factory.Mappers;

/**
* @author Filip Hrisafov
*/
@Mapper(unmappedTargetPolicy = ReportingPolicy.ERROR)
public interface CareProviderMapper {

CareProviderMapper INSTANCE = Mappers.getMapper( CareProviderMapper.class );

@Mapping(target = "id", source = "externalId")
@Mapping(target = "street", source = "address.street")
@Mapping(target = "city", source = "address.city")
CareProviderDto map(CareProvider source);
}
26 changes: 26 additions & 0 deletions ...urces/recordsTest/src/test/java/org/mapstruct/itest/records/nested/NestedRecordsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/*
* Copyright MapStruct Authors.
*
* Licensed under the Apache License version 2.0, available at http://www.apache.org/licenses/LICENSE-2.0
*/
package org.mapstruct.itest.records.nested;

import java.util.Arrays;

import static org.assertj.core.api.Assertions.assertThat;

import org.junit.Test;

public class NestedRecordsTest {

@Test
public void shouldMapRecord() {
CareProvider source = new CareProvider( "kermit", new Address( "Sesame Street", "New York" ) );
CareProviderDto target = CareProviderMapper.INSTANCE.map( source );

assertThat( target ).isNotNull();
assertThat( target.id() ).isEqualTo( "kermit" );
assertThat( target.street() ).isEqualTo( "Sesame Street" );
assertThat( target.city() ).isEqualTo( "New York" );
}
}
6 changes: 5 additions & 1 deletion processor/src/main/java/org/mapstruct/ap/internal/model/common/TypeFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,11 @@ public List<Type> getThrownTypes(Accessor accessor) {
if (accessor.getAccessorType().isFieldAssignment()) {
return new ArrayList<>();
}
return extractTypes( ( (ExecutableElement) accessor.getElement() ).getThrownTypes() );
Element element = accessor.getElement();
if ( element instanceof ExecutableElement ) {
return extractTypes( ( (ExecutableElement) element ).getThrownTypes() );
}
return new ArrayList<>();
}

private List<Type> extractTypes(List<? extends TypeMirror> typeMirrors) {
Expand Down