Skip to content

Fork/feature/spring canonical constructor constructor inject#3582

Closed
zyberzebra wants to merge 11 commits intomapstruct:mainfrom
zyberzebra:fork/feature/spring-canonical-constructor-constructor-inject
Closed

Fork/feature/spring canonical constructor constructor inject#3582
zyberzebra wants to merge 11 commits intomapstruct:mainfrom
zyberzebra:fork/feature/spring-canonical-constructor-constructor-inject

Conversation

@zyberzebra
Copy link
Copy Markdown
Contributor

built on: #3546
Trying to help :)

@filiphr
Copy link
Copy Markdown
Member

filiphr commented Apr 28, 2024

@zyberzebra how is creating a separate PR helping with #3546? @TheAndreyy already said that he'll look into your comments, so please give them time to do that.

I'll close this PR because we already have PR #3546 for this.

@filiphr filiphr closed this Apr 28, 2024
@zyberzebra
Copy link
Copy Markdown
Contributor Author

zyberzebra commented Apr 28, 2024

@filiphr Ah, sorry, my intent was to experiment with what he already did and just post what I came up with locally so far:)
Basically, I wanted to link to my commit, to show my experiment to @TheAndreyy, with the Idea that he might see something usefull.
The Pull-Request was a mistake on me.
Not trying to steal something :)

@filiphr
Copy link
Copy Markdown
Member

filiphr commented Apr 28, 2024

Not trying to steal something :)

I didn't even think that you wanted to do this 😄.

I think that you can just share a link to your commit in your comments in #3546. @TheAndreyy would be able to see it then there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants