Conversation
|
Thanks a lot for the acknowledgement, @thunderhook! I will have to take a look at it sometime to learn how it was implemented. |
filiphr
left a comment
There was a problem hiding this comment.
Looks good to me. I think some small changes could be done though to make the tests clearer. Let me know what you think @thunderhook
processor/src/main/java/org/mapstruct/ap/internal/model/PropertyMapping.java
Outdated
Show resolved
Hide resolved
...pertyname/sourcepropertyname/ConditionalMethodForCollectionMapperWithSourcePropertyName.java
Outdated
Show resolved
Hide resolved
...itional/propertyname/sourcepropertyname/ConditionalMethodInMapperWithSourcePropertyName.java
Outdated
Show resolved
Hide resolved
...nal/propertyname/sourcepropertyname/ConditionalMethodInUsesMapperWithSourcePropertyName.java
Outdated
Show resolved
Hide resolved
|
Thank you! Good points. I have rewritten the tests so that the collection also has a different name. I'm not sure how to solve it. I don't quite understand the logic that is implemented with those |
|
Got it. As suspected, this problem was caused by a reordered mapping method. The @filiphr Could you please take another look? Thanks in advance. |
|
Thanks @thunderhook. The changes looked good, I've merged this |
Finally took the time to figure it out. I used the patch of @aboqasem mentioned in #3323 (comment) and finished the implementation. I think he should also be mentioned as co-author.
Closes #3323