#3463 DefaultBuilderProvider should be able to handle methods in parent interfaces#3492
Merged
filiphr merged 2 commits intomapstruct:mainfrom Jan 28, 2024
Merged
#3463 DefaultBuilderProvider should be able to handle methods in parent interfaces#3492filiphr merged 2 commits intomapstruct:mainfrom
filiphr merged 2 commits intomapstruct:mainfrom
Conversation
…s in parent interfaces
thunderhook
approved these changes
Dec 29, 2023
Contributor
thunderhook
left a comment
thunderhook
left a comment
There was a problem hiding this comment.
Looks good to me. I was wondering if something should be added to the docs. But there is nothing stated about parent (builder) classes or interfaces in general. So I think it's fine to leave it as it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3463