#3334: Support returning unmodifiable collections and maps#3356
Open
j-be wants to merge 5 commits intomapstruct:mainfrom
Open
#3334: Support returning unmodifiable collections and maps#3356j-be wants to merge 5 commits intomapstruct:mainfrom
j-be wants to merge 5 commits intomapstruct:mainfrom
Conversation
Member
|
Thanks for your work on this @j-be. I managed to review it and it is a really good direction. There are some things that are still missing:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the introduction of
recordinto the language, immutable datatypes are a great way to move stuff around in Java in an efficient and safe (as in thread-safe) way.Providing immutable - or in Java terms: unmodifiable - collections provides another piece to the puzzle.
This PR introduces a new annotation,
@Unmodifiable, which if put on apstract mapper methods lets them return unmodifiable collections.Fixes #3334