Skip to content

#3163: Strip wild card when checking for type assignability#3349

Merged
filiphr merged 1 commit intomapstruct:mainfrom
filiphr:3163
Aug 13, 2023
Merged

#3163: Strip wild card when checking for type assignability#3349
filiphr merged 1 commit intomapstruct:mainfrom
filiphr:3163

Conversation

@filiphr
Copy link
Member

@filiphr filiphr commented Aug 1, 2023

Fixes #3163

@filiphr
Copy link
Member Author

filiphr commented Aug 1, 2023

@Zegveld you were right about #3163 and #3007. Therefore, I've split this up into a separate PR. Your name is still attach to it.

I also cleaned up the tests a bit to remove the not needed noise from Immutables.

While working on this I also realised that if we have Optional<? super SomeType> the isAssignableTo might not work correctly. Can you please perhaps add a test case for that here as well?

@filiphr filiphr mentioned this pull request Aug 1, 2023
@filiphr filiphr merged commit 8cc2bdd into mapstruct:main Aug 13, 2023
@filiphr filiphr deleted the 3163 branch August 13, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MapStruct no longer handles generic mapping methods (in conjunction with immutables) after upgrading from 1.4.x to version 1.5.x

1 participant