simplified some expressions, redundant expressions removed#3292
simplified some expressions, redundant expressions removed#3292filiphr merged 4 commits intomapstruct:mainfrom
Conversation
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
Thanks for this cleanups @anton-erofeev. I only have one small remark, see my comment
| for (Iterator<? extends TypeMirror> iterator = unusedPermittedSubclasses.iterator(); | ||
| iterator.hasNext(); ) { | ||
| if ( ctx.getTypeUtils().isSameType( iterator.next(), subClassOption.getSource() ) ) { | ||
| iterator.remove(); | ||
| } | ||
| } | ||
| unusedPermittedSubclasses.removeIf( | ||
| typeMirror -> ctx.getTypeUtils().isSameType(typeMirror, subClassOption.getSource())); |
There was a problem hiding this comment.
I don't like this change because it means that a new anonymous class has to be created to capture the subClassOption. I prefer not to create new objects for things like this
There was a problem hiding this comment.
ok, I reverted this change, thanks
anton-erofeev
force-pushed
the
refactoring
branch
from
c0a94f0 to
cca864f
Compare
|
@anton-erofeev seems like there are some formatting issues. Can you have a look at it please? |
updated but it looks like I can't run checks |
|
You are contributing for the first time @anton-erofeev and that's why the checks don't run automatically. I need to approve them in order for them to run. Just did that, if everything is OK, we'll merge this. For your next contributions this won't be necessary. |
processor/src/test/java/org/mapstruct/ap/test/nestedbeans/HouseDto.java
Outdated
Show resolved
Hide resolved
|
thank @anton-erofeev |
2 participants
No description provided.