Conversation
…earch for the next method.
sjaakd
reviewed
Oct 1, 2022
processor/src/main/java/org/mapstruct/ap/internal/model/common/Type.java
Outdated
Show resolved
Hide resolved
sjaakd
reviewed
Oct 1, 2022
processor/src/main/java/org/mapstruct/ap/internal/model/common/Type.java
Show resolved
Hide resolved
added 2 commits
October 1, 2022 14:19
…o format javadoc for 'ResolvedPair resolveParameterToType(Type declared, Type parameterized)'.
sjaakd
approved these changes
Oct 1, 2022
Member
|
I haven't reviewed the PR fully yet. However, I tried it for the example in #3163 and it isn't working as expected. We should investigate whether this should also fix that. |
Contributor
Author
I'll take a look at it. |
added 2 commits
April 15, 2023 13:10
…f wildcard information for checking assignability.
Contributor
Author
|
It seems to be a different problem. I've added the fix here, but perhaps it should be a separate PR. |
Member
I see. Indeed it does make sense to put the fix in a separate PR. I initially thought that it is the same root cause (I didn't really try it out) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was doing a lot of generics stuff lately, so figured I'd also give this one a try.
Debugging I noticed that it did the second match check with the
sourceTypethat had the unconverted genericT.Figured I'd give it a shot at replacing this generic to get successful matching going.
closes #2663