Conversation
…ep-method-annotations # Conflicts: # processor/src/main/java/org/mapstruct/ap/internal/model/MappingMethod.java # processor/src/main/resources/org/mapstruct/ap/internal/model/BeanMappingMethod.ftl # processor/src/main/resources/org/mapstruct/ap/internal/model/IterableMappingMethod.ftl # processor/src/main/resources/org/mapstruct/ap/internal/model/MapMappingMethod.ftl # processor/src/main/resources/org/mapstruct/ap/internal/model/StreamMappingMethod.ftl # processor/src/test/java/org/mapstruct/ap/test/bugs/_2773/Issue2773Test.java
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
Thanks for the changes @chenzijia12300.
I've left some comments. Something more general, I do not think that adding a default deprecatedMethod to the top level Method is the right approach for this. While reviewing this one I realised that we are missing some things for annotations in other methods and I opened #2983.
Sorry, but we'll need to wait a bit before we can integrate this one. Would you be interested in working on some other issue in the meantime?
processor/src/main/java/org/mapstruct/ap/internal/model/Mapper.java
Outdated
Show resolved
Hide resolved
processor/src/main/java/org/mapstruct/ap/internal/model/BeanMappingMethod.java
Show resolved
Hide resolved
processor/src/main/resources/org/mapstruct/ap/internal/model/BeanMappingMethod.ftl
Show resolved
Hide resolved
|
@filiphr Thank you for reviewing my code and pointing out the relevant bad code, I'm happy to deal with other issues |
|
I think that we can finally come back to this one @chenzijia12300 and I think that doing it from scratch would be the best. I think that the best solution for this is to do this in Do you agree with this @chenzijia12300? |
|
@filiphr Sounds like a great idea, I'll try to implement it |
|
Closing this PR in favour of #2996 |
2 participants
Try to implement feat: #2773