#2773 feat: Copy the method annotation to the implementation method#2960
Conversation
|
Thanks for raising this PR @chenzijia12300. We currently have PR #2792 which is doing an extensive changes in our implementation and how we handle passing annotations to the generated methods. Once this PR is merged, we are going to be able to look into this PR and #2773 |
|
I've looked at your implementation of annotation passing, and it feels much better than mine, and I'm looking forward to the final result of #2792 😊 |
|
@chenzijia12300 we've finally merged #2792 into main. Are you interested in trying to add the functionality of #2773 on top of what we added on main? I think that for now we should only copy the |
|
Yes I am interested, thank you for the ideas 😊 |
|
Great @chenzijia12300, then go for it. If you have any questions, you know where to find us 😉 |
6eeaff8 to
54321d6
Compare
|
@chenzijia12300 I think that you pushed main into your branch and Github thought that it was merged. I got confused for a second about why this was saying that it was merged |
|
(⊙﹏⊙) I don't quite understand, do I need to create a new branch and push it? |
I tried to implement it as it is in #2773.
this is my first time submitting code for an open source project, I hope it works, if there is anything wrong, I will improve it