Skip to content

#2773 feat: Copy the method annotation to the implementation method#2960

Merged
chenzijia12300 merged 0 commit intomapstruct:mainfrom
chenzijia12300:keep-method-annotations
Aug 20, 2022
Merged

#2773 feat: Copy the method annotation to the implementation method#2960
chenzijia12300 merged 0 commit intomapstruct:mainfrom
chenzijia12300:keep-method-annotations

Conversation

@chenzijia12300
Copy link
Contributor

I tried to implement it as it is in #2773.
this is my first time submitting code for an open source project, I hope it works, if there is anything wrong, I will improve it

@filiphr
Copy link
Member

filiphr commented Aug 17, 2022

Thanks for raising this PR @chenzijia12300. We currently have PR #2792 which is doing an extensive changes in our implementation and how we handle passing annotations to the generated methods. Once this PR is merged, we are going to be able to look into this PR and #2773

@chenzijia12300
Copy link
Contributor Author

I've looked at your implementation of annotation passing, and it feels much better than mine, and I'm looking forward to the final result of #2792 😊

@filiphr
Copy link
Member

filiphr commented Aug 20, 2022

@chenzijia12300 we've finally merged #2792 into main. Are you interested in trying to add the functionality of #2773 on top of what we added on main? I think that for now we should only copy the @Deprecated annotations and leave the rest untouched. People can use @AnnotateWith if they want to pass some other annotations to the implementation

@chenzijia12300
Copy link
Contributor Author

Yes I am interested, thank you for the ideas 😊

@filiphr
Copy link
Member

filiphr commented Aug 20, 2022

Great @chenzijia12300, then go for it. If you have any questions, you know where to find us 😉

@chenzijia12300 chenzijia12300 merged commit 54321d6 into mapstruct:main Aug 20, 2022
@chenzijia12300 chenzijia12300 force-pushed the keep-method-annotations branch from 6eeaff8 to 54321d6 Compare August 20, 2022 15:23
@filiphr
Copy link
Member

filiphr commented Aug 20, 2022

@chenzijia12300 I think that you pushed main into your branch and Github thought that it was merged. I got confused for a second about why this was saying that it was merged

@chenzijia12300
Copy link
Contributor Author

(⊙﹏⊙) I don't quite understand, do I need to create a new branch and push it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants