#1997 Use builders to construct empty objects in update wrapper#2733
Conversation
sjaakd
left a comment
sjaakd
left a comment
There was a problem hiding this comment.
Factory methods accept source parameters (I believe). However, I don't think we use them in property mappings, right? (Only for constructing a return type). The case that you test is creating a default empty object with a builder.
Would it be interesting to se what happens if we do accept a source parameter (for the non default case)? I guess that would be a different PR, right? The use case would be an extension of this one though. Jus as using object factories for property mappings.
Yes they do access source parameters and they still do. This is done in line 420 in The change that this PRs is doing is to use the builder if there is one for constructing the target object for update mappings. |
2 participants
Fixes #1997