#2515 Added ambiguous constructors to ambiguous constructor error mes… #2516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Good catch @basclaessen. Looking at the tests, I am not sure how I feel about eclipse 😄 . I would rather craft the elements on our side appropriately, so our Eclipse users also see better messages 😄. Can you please do that as well? |
Contributor
Author
|
@filiphr Sure! |
filiphr
reviewed
Aug 14, 2021
Member
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
Thanks for the changes @basclaessen. I've added some small suggestion (which I will accept and then merge this PR).
processor/src/main/java/org/mapstruct/ap/internal/model/BeanMappingMethod.java
Outdated
Show resolved
Hide resolved
...ssor/src/test/java/org/mapstruct/ap/test/constructor/erroneous/ErroneousConstructorTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ambiguous constructors to ambiguous constructor error message
Fixes: #2515