#2318 Fix missing mapping when source is redefined#2321
Closed
tmonney wants to merge 1 commit intomapstruct:masterfrom
Closed
#2318 Fix missing mapping when source is redefined#2321tmonney wants to merge 1 commit intomapstruct:masterfrom
tmonney wants to merge 1 commit intomapstruct:masterfrom
Conversation
Member
|
Closing this in favour of #2332 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naive attempt at fixing #2318 by not considering redefined source mappings for exclusion.
I am absolutely not sure if this is the right way to do it but at least it fixes the problem without breaking the unit tests of related issue #2101.