@filiphr I am sorry for the delay 😄

@filiphr Are you sure that lombok-mapstruct-binding should be among annotation processors? I use it as a dependency and it worked to me. I have created a repository to demonstrate it. Would you take a look?

• Repository: https://github.com/Nikolas-Charalambidis/mapstruct-1.4.1-with-lombok-1.18.16
• Test run: https://github.com/Nikolas-Charalambidis/mapstruct-1.4.1-with-lombok-1.18.16/actions

Correct me if I am wrong.

It probably works in both cases, but it is a dependency that is only needed during the annotation processing, that's why I said that it should be in the annotationProcessorPaths. That jar is not needed for the compilation of the project nor is needed during runtime. It contains an implementation of an SPI that MapStruct uses and checks whether Lombok has run.

Best practices for us is to avoid having users putting dependencies that are only needed for annotation processing on their classpath.

@filiphr You are right. I have committed the fix as you said 😄 Please take a look and squash the commits on merge, if no further edits are needed.

However, I am a bit confused... out of curiosity, I removed lombok-mapstruct-binding and the build still somehow passed.

Honestly, I can't explain it. Sometimes Lombok and MapStruct work without anything specific when they are invoked in a particular order. However, lombok-mapstruct-binding is needed as we've had number of new issues created that MapStruct and Lombok no longer work together due to users missing that dependency.

Thanks for the changes