extra-test-jaxbelem #1737
Merged
extra-test-jaxbelem #1737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We don't really have to add an issue. Looks OK to me (tests are failing due to missing classes). Why not just put everything in the top |
Contributor
Author
Hard do debug.. All mappers come by + all mapping methods in each test case. |
Member
|
That is completely valid, I agree with you |
Contributor
Author
|
thanks for reviewing.. |
Contributor
Author
|
now to convince travis 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll adapt the commit name later to an issue (to be written, or refer to the old issue for which I provided extra unit test)... But have a look..
There are things I forgot in the 2 step mapping which assure this goes right. It seems that rather than using conversion / built in directly, we only use the source-return types and than still resolve the method. That makes sure it works.. I probably need to add some additional comment to make this clear.