#1719 strange error message for selecting collection update methods#1724
Merged
sjaakd merged 2 commits intomapstruct:masterfrom Feb 25, 2019
Merged
#1719 strange error message for selecting collection update methods#1724sjaakd merged 2 commits intomapstruct:masterfrom
sjaakd merged 2 commits intomapstruct:masterfrom
Conversation
sjaakd
commented
Feb 17, 2019
processor/src/main/java/org/mapstruct/ap/internal/model/PropertyMapping.java
Outdated
Show resolved
Hide resolved
filiphr
requested changes
Feb 24, 2019
Member
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
Looks good, just a small remark as the test isn't really testing what you want 😉
processor/src/test/java/org/mapstruct/ap/test/bugs/_1719/Issue1719Test.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
cool another GitHub feature.. Re-review.. |
filiphr
approved these changes
Feb 25, 2019
Member
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
Cool feature from GitHub indeed. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there's the strange error message as described in the PR..
For adder methods MapStuct cannot generate an update method. MapStruct would cannot know how to remove objects from the child-parent relation. It cannot even assume that the the collection can be cleared at forehand. Therefore the only sensible choice is for MapStruct to create a create method for the target elements.