Adding Isochrone API support#988
Conversation
|
Would love 👁👁 on this when you get a chance @osana . No rush on my end.
Any idea what I'm doing wrong? I'm not very familiar with
|
|
@langsmith You are missing Also |
|
D'oh. Thanks @osana . Just pushed refactoring to address |
|
💪 Make sure |
|
@langsmith tags should be 4.6.0 (I believe) as this is a new feature and we are currently at 4.5.0 |
🤦♂️ , right, right. |
|
fyi, the |
810d94a to
4d227be
Compare
a203e6f to
fdfec78
Compare
|
|
||
| public class IsochroneTestUtils extends TestUtils { | ||
| protected static final String ISOCHRONE_WITH_POLYGONS_VALID = "isochroneWithPolygons.json"; | ||
| protected static final String ISOCHRONE_NO_POLYGONS_VALID = "isochroneNoPolygons.json"; |
There was a problem hiding this comment.
This one does not seem to be used.
It looks like all the tests will be using : ISOCHRONE_WITH_POLYGONS_VALID
fdfec78 to
e909a5d
Compare
osana
left a comment
There was a problem hiding this comment.
Another thought that we usually allow a List of objects to be given to a Builder, that in turn creates a String out of a list that is request friendly.
👍 Ok @osana , I just pushed a commit which enables passing through |
0f646f5 to
13b9448
Compare
a3b39d1 to
13e81ac
Compare
|
Ok @osana . I've adjusted the contour minutes and colors methods to take |
osana
left a comment
There was a problem hiding this comment.
I think this is looking pretty good.
There is one thing would be nice to fix.
You could say that there are two types of tests:
- the ones that test exceptions and request generation
- the ones that use mock fixtures
The mock fixtures ones need to have requests match the request in the fixture. Otherwise, when we do get a failing test, it is misleading to look at the request parameters.
73ede3b to
61cb5b1
Compare
61cb5b1 to
e3428fa
Compare



This pr resolves #905 by adding support for the Mapbox Isochrone API.
As @zugaldia said in #905 (comment), this isochrone support work is basically the same that was done to add support for the Tilequery API.
The Mapbox Android demo app has an Isochrone API example (pr is here), but the API is interacted with in that example in a more raw way than using a formal Mapbox Java SDK wrapper.