Added automatic choosing of POST method when a method is not specified and the url for a get call is longer than 1024*8#977
Merged
Conversation
…d and the url for a get call is longer than 1024*8
osana
approved these changes
Feb 20, 2019
Guardiola31337
left a comment
Guardiola31337
left a comment
Contributor
There was a problem hiding this comment.
Thanks @devotaaabel for running with this.
Could you cut an equivalent PR for Map Matching when you have a chance?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to the
MapboxDirectionsAPI to choose the appropriate http method (get vs. post) based on the length of the url. If thegeturl is longer than8 * 1024characters, then it uses post. The developer can still specify a specific method to use if they would like, and that will override this behavior.