Skip to content

Add via waypoints support to MapboxDirections#959

Merged
Guardiola31337 merged 1 commit into
masterfrom
pg-956-via-waypoints
Feb 8, 2019
Merged

Add via waypoints support to MapboxDirections#959
Guardiola31337 merged 1 commit into
masterfrom
pg-956-via-waypoints

Conversation

@Guardiola31337

Copy link
Copy Markdown
Contributor

Fixes #956

  • Adds via waypoints support to MapboxDirections

@Guardiola31337 Guardiola31337 self-assigned this Feb 8, 2019
@Guardiola31337 Guardiola31337 force-pushed the pg-956-via-waypoints branch 5 times, most recently from db62802 to 449941b Compare February 8, 2019 19:21
@osana

osana commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

@Guardiola31337 Two questions:

  • could you add a test to make sure that waypoints are being added to the request string
  • CI changes ? I am guessing that will be changed.

@Guardiola31337

Copy link
Copy Markdown
Contributor Author

@osana

  • could you add a test to make sure that waypoints are being added to the request string

Of course! This is updated and ready for another round of 👀

  • CI changes ? I am guessing that will be changed.

Yeah, I've released momentarily a SNAPSHOT to test OP's changes in the Navigation side. It's already reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants