Remove character waypoint names limit from MapboxMapMatching and MapboxDirections#941
Merged
Merged
Conversation
danesfeder
approved these changes
Dec 17, 2018
danesfeder
left a comment
danesfeder
left a comment
Contributor
There was a problem hiding this comment.
Thanks for confirming this was okay with the Directions team @Guardiola31337 🚢
osana
reviewed
Dec 17, 2018
osana
left a comment
osana
left a comment
Contributor
There was a problem hiding this comment.
it would be good to modify/move tests instead of deleting them.
Directions have DirectionsError that would catch those.
Also gives customers and idea on how the Error is reported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MapboxMapMatchingandMapboxDirectionsRefs. #940 (review)
This PR removes the hard-coded check for a max of 500 characters total for all waypoint names in
MapboxMapMatchingandMapboxDirections👀 https://github.com/mapbox/api-directions/pull/1625We shouldn't enforce this in the java code - the error code / message will still be returned from the server.
cc @danpaz @danpat