Skip to content

Remove coordinate limit from MapboxMapMatching #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danesfeder merged 1 commit into from
Dec 17, 2018
Merged

Remove coordinate limit from MapboxMapMatching #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions services-matching/src/main/java/com/mapbox/api/matching/v5/MapboxMapMatching.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,10 +697,6 @@ public MapboxMapMatching build() {
+ " request.");
}

if (coordinates.size() > 100) {
throw new ServicesException("Maximum of 100 coordinates are allowed for this API.");
}

if (radiuses != null && radiuses.length != coordinates.size()) {
throw new ServicesException(
"There must be as many radiuses as there are coordinates.");
Expand Down
17 changes: 0 additions & 17 deletions services-matching/src/test/java/com/mapbox/api/matching/v5/MapboxMapMatchingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,23 +116,6 @@ public void build_exceptionThrownWhenLessThanTwoCoordsProvided() throws Exceptio
mapMatching.executeCall();
}

@Test
public void build_throwsExceptionWhenCoordsOverOneHundred() throws Exception {
thrown.expect(ServicesException.class);
thrown.expectMessage(
startsWith("Maximum of 100 coordinates are allowed for this API."));
List<Point> coordinates = new ArrayList<>();
for (int i = 0; i < 101; i++) {
coordinates.add(Point.fromLngLat(1.0 + i, 2.0 + i));
}
MapboxMapMatching mapMatching = MapboxMapMatching.builder()
.coordinates(coordinates)
.baseUrl("https://foobar.com")
.accessToken(ACCESS_TOKEN)
.build();
mapMatching.executeCall();
}

@Test
public void build_throwsExceptionWhenNotMatchingRadiusesForEachCoord() throws Exception {
thrown.expect(ServicesException.class);
Expand Down