Remove coordinate limit from MapboxMapMatching#940
Merged
Conversation
Guardiola31337
approved these changes
Dec 17, 2018
Guardiola31337
left a comment
Guardiola31337
left a comment
Contributor
There was a problem hiding this comment.
Thanks for running with this @danesfeder 🚢
Guardiola31337
left a comment
Guardiola31337
left a comment
Contributor
There was a problem hiding this comment.
Wondering if the same thing applies for waypointNames 🤔
osana
reviewed
Dec 17, 2018
osana
left a comment
osana
left a comment
Contributor
There was a problem hiding this comment.
I believe MapMatching has and Error handling.
It would be good to modify/move the test instead of deleting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the hard-coded check for a max of 100 coordinates in
MapboxMapMatching. Developers are able to pay for and configure higher coordinate limits, so we shouldn't enforce this in the java code - the error code / message will still be returned from the server.cc @kbauhaus @Guardiola31337