Skip to content

Remove waypoint limit check #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Guardiola31337 merged 1 commit into from
Nov 30, 2018
Merged

Remove waypoint limit check #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions services-directions/src/main/java/com/mapbox/api/directions/v5/MapboxDirections.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,10 +421,6 @@ public Builder destination(@NonNull Point destination) {
* @since 3.0.0
*/
public Builder addWaypoint(@NonNull Point waypoint) {
if (coordinates.size() > 23) {
throw new ServicesException("A max of 25 coordinates including the origin and destination"
+ "values can be used inside your request.");
}
coordinates.add(waypoint);
return this;
}
Expand Down
11 changes: 0 additions & 11 deletions services-directions/src/test/java/com/mapbox/api/directions/v5/MapboxDirectionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,17 +118,6 @@ public void sanity() throws Exception {
Assert.assertNotNull(mapboxDirections);
}

@Test
public void addWaypoint_maxWaypointsAdded() throws Exception {
thrown.expect(ServicesException.class);
thrown.expectMessage("A max of 25 coordinates including the origin and destination");
MapboxDirections.Builder mapboxDirectionsBuilder = MapboxDirections.builder();
for (int i = 0; i < 25; i++) {
mapboxDirectionsBuilder.addWaypoint(Point.fromLngLat(i, i + 1));
}
mapboxDirectionsBuilder.accessToken(ACCESS_TOKEN).build().executeCall();
}

@Test
public void build_noAccessTokenExceptionThrown() throws Exception {
thrown.expect(IllegalStateException.class);
Expand Down