Added approaches request paramenter to Directions and MapMatching#827
Merged
Conversation
danesfeder
approved these changes
May 30, 2018
danesfeder
left a comment
danesfeder
left a comment
Contributor
There was a problem hiding this comment.
@osana this looks good thanks for the work on this! Just some minor javadoc updates to update before merging - will still unblock you ✅
|
|
||
|
|
||
| /** | ||
| * Optionally used to indicate how map matched routes consider |
Contributor
There was a problem hiding this comment.
Is how map matched a typo here?
|
|
||
| abstract Builder approaches(@Nullable String approaches); | ||
|
|
||
|
|
| public abstract String requestUuid(); | ||
|
|
||
| /** | ||
| * Used to indicate how map matched routes consider |
Contributor
There was a problem hiding this comment.
I think we should make this javadoc not specific to map match vs. directions API, as it's used in both
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #820