Jenny directionsapi 368#428
Merged
Merged
Conversation
|
Commit |
|
List of things that still need to be done:
|
cammace
force-pushed
the
jenny-directionsapi-368
branch
from
d6e52c9 to
57a8add
Compare
|
Path and marker have been added. Only API that needs exposure still is the GeoJSON. cc: @zugaldia |
zugaldia
requested changes
Apr 14, 2017
| .setStrokeWidth(5) | ||
| .build(); | ||
|
|
||
|
|
| <item>Lost</item> | ||
| <item>Google Play Services</item> | ||
| </string-array> | ||
| <string name="title_activity_static_image_with_annotations">Static Image With AnnotationsActivity |
Member
There was a problem hiding this comment.
Duplicated: there's a title_static_image_with_annotations above.
| * | ||
| * @since 2.1.0 | ||
| */ | ||
| public class Marker { |
Member
There was a problem hiding this comment.
Could we call this StaticMarkerAnnotation instead?
| * | ||
| * @since 2.1.0 | ||
| */ | ||
| public class Polyline { |
Member
There was a problem hiding this comment.
Could we call this StaticPolylineAnnotation instead?
| } | ||
| } | ||
| } | ||
|
|
zugaldia
requested changes
Apr 14, 2017
|
|
||
| if (builder.getPrecision() > 0) { | ||
| String pattern = "0." + new String(new char[builder.getPrecision()]).replace("\0", "0"); | ||
| DecimalFormat df = (DecimalFormat) DecimalFormat.getInstance(Locale.US); |
Member
There was a problem hiding this comment.
Instead of having custom code here for formatting, let's extend the code in #424 for this use case?
cammace
force-pushed
the
jenny-directionsapi-368
branch
from
bc19f69 to
8e67eec
Compare
cammace
force-pushed
the
jenny-directionsapi-368
branch
from
765ebf6 to
0a2becd
Compare
zugaldia
approved these changes
Apr 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a marker overlay on static image maps.