Support for directions matrix#418
Merged
Merged
Conversation
Member
|
Besides mapbox/mapbox-android-demo#263, let's add an example to the Test App in MAS too. |
zugaldia
requested changes
Mar 30, 2017
| .addConverterFactory(GsonConverterFactory.create()) | ||
| .build(); | ||
|
|
||
|
|
| @Query("sources") String sources | ||
| ); | ||
|
|
||
|
|
| if (profile == null) { | ||
| throw new ServicesException( | ||
| "A profile is required for the Directions Matrix API. Use one of the profiles found in the" | ||
| + "DirectionsCriteria.java file."); |
Member
There was a problem hiding this comment.
in the DirectionsCriteria values
|
|
||
| if (profile.equals(DirectionsCriteria.PROFILE_DRIVING_TRAFFIC)) { | ||
| throw new ServicesException( | ||
| "The directions matrix doesn't support the driving traffic profile."); |
| if (!profile.equals(DirectionsCriteria.PROFILE_DRIVING) | ||
| && !profile.equals(DirectionsCriteria.PROFILE_CYCLING) | ||
| && !profile.equals(DirectionsCriteria.PROFILE_WALKING)) { | ||
| throw new ServicesException("Profile must be one of the constants found inside the DirectionsCriteria file."); |
|
|
||
| if (coordinates.size() > 25) { | ||
| throw new ServicesException( | ||
| "All profiles allows for maximum of 25 coordinates."); |
cammace
force-pushed
the
cam-directions-matrix
branch
from
59f3efc to
5ad6697
Compare
added 2 commits
March 30, 2017 13:29
Member
|
@cammace Still missing #418 (comment). |
zugaldia
approved these changes
Mar 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #406
Adds support for the directions matrix v1 recently launched
Check List