Add support for direction annotations#417
Merged
Merged
Conversation
|
@cammace, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zugaldia, @tobrun and @ivovandongen to be potential reviewers. |
zugaldia
requested changes
Mar 30, 2017
| && !annotationEntry.equals(DirectionsCriteria.ANNOTATION_DURATION) | ||
| && !annotationEntry.equals(DirectionsCriteria.ANNOTATION_SPEED)) { | ||
| throw new ServicesException( | ||
| "Annotation value must be one of the constants found inside the DirectionsCriteria file"); |
| "Annotation request can only contain one of the three DirectionsCriteria constants."); | ||
| } | ||
|
|
||
| System.out.println(annotation[0]); |
| client.enqueueCall(new Callback<DirectionsResponse>() { | ||
| @Override | ||
| public void onResponse(Call<DirectionsResponse> call, Response<DirectionsResponse> response) { | ||
| Log.d(LOG_TAG, call.request().url().toString()); |
Member
There was a problem hiding this comment.
If you meant to leave this line, let's add a more detailed message of what the developer is seeing.
zugaldia
approved these changes
Mar 30, 2017
cammace
force-pushed
the
cam-annotations
branch
from
e93e383 to
66c3353
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #334