Skip to content

Introduce PRECISION_5 and PRECISION_6 constants #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zugaldia merged 2 commits into from
Feb 8, 2017
Merged

Introduce PRECISION_5 and PRECISION_6 constants #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
168edb5
add PRECISION_5 and PRECISION_6 to be explicit about precision values
zugaldia Feb 8, 2017
2e87ddd
use Constants.PRECISION_6 as an example in MapMatchingActivity
zugaldia Feb 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mapbox/app/src/main/java/com/mapbox/services/android/testapp/utils/MapMatchingActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,10 @@ public void onResponse(Call<MapMatchingResponse> call, Response<MapMatchingRespo
// Check that the map matching API response is "OK".
if (response.code() == 200) {
// Convert the map matched response list from position to latlng coordinates.
// By default, the SDK uses MapMatchingCriteria.GEOMETRY_POLYLINE_6, therefore
// you need Constants.PRECISION_6 for the decode to be right
String geometry = response.body().getMatchings().get(0).getGeometry();
List<Position> positions = PolylineUtils.decode(geometry, Constants.OSRM_PRECISION_V4);
List<Position> positions = PolylineUtils.decode(geometry, Constants.PRECISION_6);
if (positions == null) {
return;
}
Expand Down
6 changes: 6 additions & 0 deletions mapbox/libjava-core/src/main/java/com/mapbox/services/Constants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,16 @@ public class Constants {
/**
* Constants for polyline encoding/decoding
*/

// Use these if you want to be explicit about the vendor
public static final int GOOGLE_PRECISION = 5;
public static final int OSRM_PRECISION_V4 = 6;
public static final int OSRM_PRECISION_V5 = 5;

// Use these if you want to be explicit about the precision
public static final int PRECISION_5 = 5;
public static final int PRECISION_6 = 6;

/**
* Default user for services
*/
Expand Down