Conversation
|
Alright, nothing that couldn't be fixed bringing some generics to the (Working sample in If this looks good to @mapbox/android we just need to bring in some test and adapt the same approach to the other clients (distance, geocoding, mapmatching, |
|
Would it make sense to also have a |
Yes, but let's wait to have some content before we create the module. For example, #4 should closed for now as it's unclear that the benefits of the Rx approach in the widget outbalance the weight of the dependency. @cammace PR is ready, care to review please? |
WIP to bring back support for Rx as part of the
libjava-services-rxmodule.The first stab at it, extending the current
MapboxDirectionsclass, works but brings an inconsistent API. Unlike with the normal client where theBuilderbrings theMapboxDirectionsinstance. Right now, we need to use them separately as we cannot use thebuildmethod:This needs one more iteration.
Fixes #131.
cc: @mapbox/android for folks familiar with Rx willing to get some 👀.