Skip to content

Split MAS into smaller submodules#251

Merged
zugaldia merged 34 commits into
masterfrom
mas-split
Jan 5, 2017
Merged

Split MAS into smaller submodules#251
zugaldia merged 34 commits into
masterfrom
mas-split

Conversation

@zugaldia

@zugaldia zugaldia commented Jan 4, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

This PR brings the following changes to MAS:

  • libjava and libandroid now live under the same (Android Studio) project.
  • These projects are now split up into: libjava-core, libjava-geojson, libjava-services, libjava-services-rx, libandroid-telemetry, libandroid-services, libandroid-ui, and app.
  • All but app will be published independently to Maven.
  • No code has been changed, except to adjust package names (which I've tried to respect the best I could).

Pending:

  • libjava-services-rx (see Support RxJava #131) and libandroid-telemetry are placeholders for now.
  • Port all gradle settings (like publish to Maven Central, checkstyle).
  • Update CI (Bitrise settings)

@mapbox/android Still a WIP but open for feedback.

@zugaldia zugaldia self-assigned this Jan 4, 2017
@zugaldia

zugaldia commented Jan 5, 2017

Copy link
Copy Markdown
Member Author

Alright, everything should be working now like before.

@tobrun @cammace great if I could get your 👀 here. I know this is a massive PR, but great if at least you can detect red flags now, we can polish the rest later in separate tickets. There are no changes to code, just to the organization of the packages into more and smaller submodules. If it helps, I just published SNAPSHOTS for all the modules and they're available on https://oss.sonatype.org/content/repositories/snapshots/com/mapbox/mapboxsdk/ (no actual releases on Maven yet).

  • libandroid-services: Equivalent to the previous android-services.
  • libandroid-telemetry: Future container for extracted telemetry.
  • libandroid-ui: UI components, for now, just the Geocoder Autocomplete.
  • libjava-core: Just models.
  • libjava-geojson: So that the SDK doesn't need to include code it doesn't need for the Runtime Styling implementation.
  • libjava-services: Equivalent to the previous java-services.
  • libjava-services-rx: RxJava extensions (to bring them back)

libjava-services-rx and libandroid-telemetry will be tackled in a separate ticket.

cammace
cammace approved these changes Jan 5, 2017
View reviewed changes

@cammace cammace left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Works successfully in the demo app

@zugaldia zugaldia changed the title [WIP] Split MAS into smaller submodules Split MAS into smaller submodules Jan 5, 2017
@zugaldia zugaldia merged commit dfebb06 into master Jan 5, 2017
@zugaldia zugaldia deleted the mas-split branch January 5, 2017 21:10
@cammace cammace mentioned this pull request Jan 5, 2017
Closed
@zugaldia zugaldia mentioned this pull request Jan 9, 2017
Merged
This was referenced Feb 7, 2017
Closed
Closed
@1ec5 1ec5 mentioned this pull request Feb 18, 2017
Closed
@zugaldia zugaldia mentioned this pull request Feb 22, 2017
Closed
9 tasks
@zugaldia zugaldia mentioned this pull request Mar 9, 2017
Closed
9 tasks
@zugaldia zugaldia mentioned this pull request Mar 17, 2017
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cammace cammace cammace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zugaldia zugaldia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zugaldia @cammace