Added direction v5 lanes and updated fixture#214
Merged
Conversation
|
@cammace, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zugaldia and @ivovandongen to be potential reviewers. |
zugaldia
requested changes
Nov 10, 2016
zugaldia
left a comment
zugaldia
left a comment
Member
There was a problem hiding this comment.
Per chat, let's use make directions-fixtures to generate the fixture, or update the make target accordingly.
Author
|
Thanks for pointing out the Makefile @zugaldia, I updated the fixture using the same API call and reset one of the test geometries back to what it was on master. |
zugaldia
approved these changes
Nov 22, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds lanes to the direction v5 models along with updating the fixtures to run test on this. Can you review please @ivovandongen.
cc: @zugaldia