add poi.landmark type to geocoder#209
Merged
Merged
Conversation
|
@sbma44, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cammace, @zugaldia and @ivovandongen to be potential reviewers. |
ivovandongen
approved these changes
Oct 31, 2016
ivovandongen
left a comment
ivovandongen
left a comment
Contributor
There was a problem hiding this comment.
@sbma44 Thanks for the PR. LGTM
Member
Author
|
Thanks @ivovandongen! Anything I need to do in connection to the version bump when I hit merge? |
|
Versioning's fine, we can always bump later down the road if needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dropped in
poi.landmark. Hoping to see what CI tests say, then take it from there. Eyes appreciated, I'm totally unfamiliar with Java development.