updated method count badge#200
Merged
Merged
Conversation
zugaldia
reviewed
Sep 20, 2016
zugaldia
left a comment
zugaldia
left a comment
Member
There was a problem hiding this comment.
Did we go from 124 in 1.3.0 to 690 in 1.3.1, or does 124 refer to an older version? We didn't add any dependencies in 1.3.1 and the number of methods should be more stable.
Author
|
Old badge was only displaying libandroid method count (which should be around 124) i've switched to libjava to more accurately reflect this SDK. |
Member
|
@cammace Makes sense, thanks. I see OkHttp and Gson being the main two contributors to that count. I believe both are a reasonable use and assumption nowadays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've switched to using mapbox-java instead to better represent this library.
cc: @zugaldia