Skip to content

Checkstyle task not working#193

Closed
Guardiola31337 wants to merge 3 commits into
mapbox:masterfrom
Guardiola31337:checkstyle-task-not-working
Closed

Checkstyle task not working#193
Guardiola31337 wants to merge 3 commits into
mapbox:masterfrom
Guardiola31337:checkstyle-task-not-working

Conversation

@Guardiola31337

Copy link
Copy Markdown
Contributor

It's related with #111
Before creating #192 I noticed that checkstyle.gradle task defined in libjava module wasn't working.
It didn't report anything. It seemed strange to me so I fixed it.
Now, you can review the checkstyle warnings running $ ./gradlew clean checkstyle.
Likewise, you can add checkstyle support into libandroid module. Let me know if you want me to do it.

@mention-bot

Copy link
Copy Markdown

@Guardiola31337, thanks for your PR! By analyzing the annotation information on this pull request, we identified @cammace and @zugaldia to be potential reviewers

@zugaldia

Copy link
Copy Markdown
Member

@Guardiola31337 Thank you for the contribution, you're on a roll :)

@cammace you've been working on this, could you review when you have a chance?

@Guardiola31337

Guardiola31337 commented Sep 12, 2016

Copy link
Copy Markdown
Contributor Author

@zugaldia You're welcome!
I don't know what happened with the Bitrise check. I can't see your Bitrise configuration (logically), but let me know if I can help because I tried it on my forked repository and is running without failing. I imagine it's just a matter of configuring the proper commands.

@zugaldia

Copy link
Copy Markdown
Member

@Guardiola31337 you can actually see our Bitrise config (you can't see the keys though :).

@Guardiola31337

Copy link
Copy Markdown
Contributor Author

@zugaldia It's true :) But I can't see the log details that you're getting on Bitrise, so I don't know which step is failing.

@cammace

cammace commented Nov 30, 2016

Copy link
Copy Markdown

Thanks for the PR @Guardiola31337, I cleaned up the gradle task slightly and set it up for libandroid also. Closing in favor of #224

@cammace cammace closed this Nov 30, 2016
@Guardiola31337 Guardiola31337 deleted the checkstyle-task-not-working branch November 30, 2016 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants