Checkstyle task not working#193
Conversation
|
@Guardiola31337, thanks for your PR! By analyzing the annotation information on this pull request, we identified @cammace and @zugaldia to be potential reviewers |
|
@Guardiola31337 Thank you for the contribution, you're on a roll :) @cammace you've been working on this, could you review when you have a chance? |
|
@zugaldia You're welcome! |
|
@Guardiola31337 you can actually see our Bitrise config (you can't see the keys though :). |
|
@zugaldia It's true :) But I can't see the log details that you're getting on Bitrise, so I don't know which step is failing. |
|
Thanks for the PR @Guardiola31337, I cleaned up the gradle task slightly and set it up for libandroid also. Closing in favor of #224 |
It's related with #111
Before creating #192 I noticed that
checkstyle.gradletask defined inlibjavamodule wasn't working.It didn't report anything. It seemed strange to me so I fixed it.
Now, you can review the checkstyle warnings running
$ ./gradlew clean checkstyle.Likewise, you can add checkstyle support into
libandroidmodule. Let me know if you want me to do it.