Skip to content

Adding country to V6StructuredInputQuery#1588

Merged
ahmedaly16 merged 1 commit into
mainfrom
aaly-country
Aug 28, 2024
Merged

Adding country to V6StructuredInputQuery#1588
ahmedaly16 merged 1 commit into
mainfrom
aaly-country

Conversation

@ahmedaly16

Copy link
Copy Markdown
Contributor

The country field is part of the Forward geocoding with structured input: https://docs.mapbox.com/api/search/geocoding#forward-geocoding-with-structured-input

So I'm adding it to our object V6StructuredInputQuery.

@ahmedaly16 ahmedaly16 requested a review from a team as a code owner August 27, 2024 14:05
@codecov

codecov Bot commented Aug 27, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.93%. Comparing base (05a7bfe) to head (b40efbc).
Report is 1 commits behind head on main.

Files Patch % Lines
...apbox/api/geocoding/v6/V6StructuredInputQuery.java 0.00% 0 Missing and 1 partial ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1588      +/-   ##
============================================
- Coverage     77.94%   77.93%   -0.02%     
  Complexity     1066     1066              
============================================
  Files           158      158              
  Lines          4448     4450       +2     
  Branches        616      617       +1     
============================================
+ Hits           3467     3468       +1     
  Misses          714      714              
- Partials        267      268       +1     
Files Coverage Δ
...geocoding/v6/V6ForwardGeocodingRequestOptions.java 95.83% <100.00%> (+0.08%) ⬆️
...apbox/api/geocoding/v6/V6StructuredInputQuery.java 56.25% <0.00%> (-3.75%) ⬇️

@ahmedaly16

Copy link
Copy Markdown
Contributor Author

@DzmitryFomchyn do you recall if the country field was left out of V6StructuredInputQuery intentionally? Or was it just missed?

@ahmedaly16 ahmedaly16 merged commit 987b2c9 into main Aug 28, 2024
@ahmedaly16 ahmedaly16 deleted the aaly-country branch August 28, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants